restore older versioning as the first versioning task

I don't know what I was thinking removing this completely
sure it is ugly
but that is why it is versioning code

__init__.py

@@ -18,7 +18,7 @@ from .utilities import prRed
 
 MANTIS_VERSION_MAJOR=0
 MANTIS_VERSION_MINOR=12
-MANTIS_VERSION_SUB=1
+MANTIS_VERSION_SUB=2
 
 classLists = [module.TellClasses() for module in [
  link_definitions,
@@ -268,7 +268,9 @@ def node_version_update(node):
         arg_map = {}
         if 'node' in required_kwargs:
             arg_map['node']=node
-        if node.bl_idname in bl_idname:
+        if 'node_tree' in required_kwargs:
+            arg_map['node_tree']=node.id_data
+        if bl_idname == 'ALL' or node.bl_idname in bl_idname:
             if do_once:
                 print (f"Updating tree {node.id_data.name} to "
                        f"{MANTIS_VERSION_MAJOR}.{MANTIS_VERSION_MINOR}.{MANTIS_VERSION_SUB}")

blender_manifest.toml

@@ -3,7 +3,7 @@ schema_version = "1.0.0"
 # Example of manifest file for a Blender extension
 # Change the values according to your extension
 id = "mantis"
-version = "0.12.1"
+version = "0.12.2"
 name = "Mantis"
 tagline = "Mantis is a rigging nodes toolkit"
 maintainer = "Nodespaghetti <josephbburg@protonmail.com>"

versioning.py

@@ -4,6 +4,104 @@
 from bpy.types import Node, NodeSocket
 from .utilities import prRed, prGreen, prPurple
 
+def version_upgrade_very_old(*args, **kwargs):
+    node = kwargs['node']
+    current_major_version = node.id_data.mantis_version[0]
+    current_minor_version = node.id_data.mantis_version[1]
+    if  current_major_version > 0: return# major version must be 0
+    if current_minor_version > 11: return# minor version must be 12 or less
+
+    # this is the old node update, very inneficient and strange and badly organized
+    NODES_REMOVED=["xFormRootNode"]
+                    # Node bl_idname, # Socket Name
+    SOCKETS_REMOVED=[("UtilityDriverVariable", "Transform Channel"),
+                    ("xFormRootNode","World Out"),
+                    ("UtilitySwitch","xForm"),
+                    ("LinkDrivenParameter", "Enable")]
+                    # Node Class           #Prior bl_idname  # prior name # new bl_idname #       new name,          # Multi
+    SOCKETS_RENAMED=[ ("LinkDrivenParameter", "DriverSocket",   "Driver",     "FloatSocket",        "Value",              False),
+                    ("DeformerHook",        "IntSocket",      "Index",      "UnsignedIntSocket",  "Point Index",        False),
+                    ("SchemaConstOutput",   "IntSocket",      "Expose when N==",      "UnsignedIntSocket",  "Expose at Index", False),]
+
+                    # NODE CLASS NAME             IN_OUT    SOCKET TYPE     SOCKET NAME     INDEX   MULTI     DEFAULT
+    SOCKETS_ADDED=[("DeformerMorphTargetDeform", 'INPUT', 'BooleanSocket', "Use Shape Key", 1,      False,    False),
+                ("DeformerMorphTargetDeform", 'INPUT', 'BooleanSocket', "Use Offset",    2,      False,    True),
+                ("UtilityFCurve",             'INPUT',  "eFCrvExtrapolationMode", "Extrapolation Mode", 0, False, 'CONSTANT'),
+                ("LinkCopyScale",             'INPUT',  "BooleanSocket", "Additive",     3,      False,    False),
+                ("DeformerHook",              'INPUT',  "FloatFactorSocket", "Influence",3,      False,    1.0),
+                ("DeformerHook",              'INPUT',  "UnsignedIntSocket", "Spline Index", 2,  False,    0),
+                ("DeformerHook",              'INPUT',  "BooleanSocket", "Auto-Bezier",  5,      False,    True),
+                ("UtilityCompare",            'INPUT',  "EnumCompareOperation", "Comparison", 0, False,    'EQUAL'),
+                ("UtilityMatrixFromCurve",    'INPUT',  "UnsignedIntSocket", "Spline Index",  1, False,    0),
+                ("UtilityMatricesFromCurve",  'INPUT',  "UnsignedIntSocket", "Spline Index",  1, False,    0),
+                ("UtilityPointFromCurve",     'INPUT',  "UnsignedIntSocket", "Spline Index",  1, False,    0),
+                ("LinkCopyScale",             'INPUT',  "FloatFactorSocket", "Power",    5,      False,    1.0),
+                ]
+
+    rename_jobs = []
+    node_tree = kwargs['node_tree']
+    try:
+        if node.bl_idname in NODES_REMOVED:
+            print(f"INFO: removing node {node.name} of type {node.bl_idname} because it has been deprecated.")
+            node.inputs.remove(socket)
+            return
+        for i, socket in enumerate(node.inputs.values()):
+            if (node.bl_idname, socket.identifier) in SOCKETS_REMOVED:
+                print(f"INFO: removing socket {socket.identifier} of node {node.name} of type {node.bl_idname} because it has been deprecated.")
+                node.inputs.remove(socket)
+            for old_class, old_bl_idname, old_name, new_bl_idname, new_name, multi in SOCKETS_RENAMED:
+                if (node.bl_idname == old_class and socket.bl_idname == old_bl_idname and socket.name == old_name):
+                    rename_jobs.append((socket, i, new_bl_idname, new_name, multi))
+        for i, socket in enumerate(node.outputs.values()):
+            if (node.bl_idname, socket.identifier) in SOCKETS_REMOVED:
+                print(f"INFO: removing socket {socket.identifier} of node {node.name} of type {node.bl_idname} because it has been deprecated.")
+                node.outputs.remove(socket)
+            for old_class, old_bl_idname, old_name, new_bl_idname, new_name, multi in SOCKETS_RENAMED:
+                if (node.bl_idname == old_class and socket.bl_idname == old_bl_idname and socket.name == old_name):
+                    rename_jobs.append((socket, i, new_bl_idname, new_name, multi))
+
+        for bl_idname, in_out, socket_type, socket_name, index, use_multi_input, default_val in SOCKETS_ADDED:
+            if node.bl_idname != bl_idname:
+                continue
+            if in_out == 'INPUT' and node.inputs.get(socket_name) is None:
+                print(f"INFO: adding socket \"{socket_name}\" of type {socket_type} to node {node.name} of type {node.bl_idname}.")
+                s = node.inputs.new(socket_type, socket_name, use_multi_input=use_multi_input)
+                try:
+                    s.default_value = default_val
+                except AttributeError:
+                    pass # the socket is read-only
+                node.inputs.move(len(node.inputs)-1, index)
+        socket_map = None
+        if rename_jobs:
+            from .utilities import get_socket_maps
+            socket_maps = get_socket_maps(node)
+        for socket, socket_index, new_bl_idname, new_name, multi in rename_jobs:
+            old_id = socket.identifier
+            print (f"Renaming socket {socket.identifier} to {new_name} in node {node.name}")
+            from .utilities import do_relink
+            if socket.is_output:
+                index = 1
+                in_out = "OUTPUT"
+                node.outputs.remove(socket)
+                s = node.outputs.new(new_bl_idname, new_name, identifier=new_name, use_multi_input=multi)
+                node.outputs.move(len(node.outputs)-1, socket_index)
+                socket_map = socket_maps[1]
+            else:
+                index = 0
+                in_out = "INPUT"
+                node.inputs.remove(socket)
+                s = node.inputs.new(new_bl_idname, new_name, identifier=new_name, use_multi_input=multi)
+                node.inputs.move(len(node.inputs)-1, socket_index)
+                socket_map = socket_maps[0]
+            socket_map[new_name] = socket_map[old_id]
+            if new_name != old_id: del socket_map[old_id] # sometimes rename just changes the socket type or multi
+            do_relink(node, s, socket_map)
+        for bl_idname, task in versioning_node_tasks:
+            if node.bl_idname in bl_idname: task(node)
+    except Exception as e:
+        prRed(f"Error updating version in node: {node.id_data.name}::{node.name}; see error:")
+        print(e)
+
 
 def version_upgrade_bone_0_12_0_from_older(*args, **kwargs):
     # we need to check if it has an array collection input and a color input
@@ -75,6 +173,7 @@ def up_0_12_1_add_inherit_color(*args, **kwargs):
 
 versioning_tasks = [
     # node bl_idname    task                required keyword arguments 
+    (['ALL'], version_upgrade_very_old, ['node_tree', 'node'],),
     (['xFormBoneNode'], version_upgrade_bone_0_12_0_from_older, ['node'],),
     (['xFormBoneNode'], up_0_12_1_add_inherit_color, ['node'],),
 ]