Browse Source

gettextprop: check result of XGetTextProperty (undefined behaviour for XFree)

Hiltjo Posthuma 8 years ago
parent
commit
99f78fa553
1 changed files with 1 additions and 2 deletions
  1. 1 2
      dwm.c

+ 1 - 2
dwm.c

@@ -910,8 +910,7 @@ gettextprop(Window w, Atom atom, char *text, unsigned int size)
 	if (!text || size == 0)
 	if (!text || size == 0)
 		return 0;
 		return 0;
 	text[0] = '\0';
 	text[0] = '\0';
-	XGetTextProperty(dpy, w, &name, atom);
-	if (!name.nitems)
+	if (!XGetTextProperty(dpy, w, &name, atom) || !name.nitems)
 		return 0;
 		return 0;
 	if (name.encoding == XA_STRING)
 	if (name.encoding == XA_STRING)
 		strncpy(text, (char *)name.value, size - 1);
 		strncpy(text, (char *)name.value, size - 1);